-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETW-3200 and FILE-6430 do no longer detect blacklisted modules #1502
Comments
That's due to an error in include/consts, GREPBINARY="grep". It should read GREPBINARY="grep -E" because in NETW-3200 and other tests I assume extended regular expressions are used. And the test should be written as:
to actually work (openSUSE Tumbleweed). Please be aware that tabulators and/or blanks might be used. |
I have amended my PR to include your very valid remark. |
to achieve the expected behaviour in 9819ac4: |
Would be great if this PR could get merged so we don't get this bug anymore. |
Describe the bug
Both tests NETW-3200 and FILE-6430 do no longer detect blacklisted modules
Version
Expected behavior
Both tests NETW-3200 and FILE-6430 detect blacklisted modules
Output
Additional context
Since commit "9819ac4" the REGEX for detecting the blacklist entries is broken.
DATA=$(${GREPBINARY} "^install \+${P} \+/bin/true$" ${ROOTDIR}etc/modprobe.conf)
and
DATA=$(${GREPBINARY} -l -s "^install \+${P} \+/bin/true$" ${ROOTDIR}etc/modprobe.d/*)
respectively, because the "" escapes the "+" and thus the "+" is expected in the output.
I fixed this to read
DATA=$(${GREPBINARY} "^install +${P} +/bin/true$" ${ROOTDIR}etc/modprobe.conf)
and
DATA=$(${GREPBINARY} -l -s "^install +${P} +/bin/true$" ${ROOTDIR}etc/modprobe.d/*)
which fulfills the original intention of allowing any number of blanks.
The text was updated successfully, but these errors were encountered: