Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should warn clients when using unexpected fields in requests. #217

Closed
1 of 4 tasks
grim-i-am opened this issue May 20, 2022 · 4 comments
Closed
1 of 4 tasks

Server should warn clients when using unexpected fields in requests. #217

grim-i-am opened this issue May 20, 2022 · 4 comments
Labels
help welcomed Good for newcomers

Comments

@grim-i-am
Copy link

grim-i-am commented May 20, 2022 •
edited
Loading

What Git revision are you using?

v5.3.0 binary

What operating system are you using, and which version?

  • Linux / Ubuntu
  • Linux / Other
  • OSX
  • Windows

Describe what the problem is?

When calling "Query/FindIntersect/RequestNext" methods with a reflection parameter, the reflection object is not sent to onMessage handler.

What should be the expected behavior?

Reflection parameter should always be reflected.
@grim-i-am grim-i-am changed the title Query method does not send back Reflection parameter Some methods do not send back Reflection parameter May 20, 2022
@KtorZ
Copy link
Member

KtorZ commented May 20, 2022 •
edited
Loading

I have never observed such behavior 🤔 , are you setting the right parameter? In requests, the reflection parameter is called mirror. Settings reflection as a parameter on requests will have no effect.

@grim-i-am
Copy link
Author

Sorry, my mistake

@KtorZ
Copy link
Member

KtorZ commented May 20, 2022

I think it's still worth adding some little code in the query parser to reject requests which would contain additional parameters, and in particular, a reflection parameter.

Mind if I rename the ticket to reflect this?

@KtorZ KtorZ added enhancement help welcomed Good for newcomers labels May 20, 2022
@grim-i-am
Copy link
Author

Mind if I rename the ticket to reflect this?

not at all, be my guest!

@KtorZ KtorZ changed the title Some methods do not send back Reflection parameter Server should warn clients when using unexpected fields in requests. May 20, 2022
@KtorZ KtorZ closed this as completed in 4a1cee0 May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help welcomed Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KtorZ @grim-i-am