Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Startup: Verify Detection & Protection #269

Open
SecUpwN opened this issue Jan 8, 2015 · 12 comments
Open

Initial Startup: Verify Detection & Protection #269

SecUpwN opened this issue Jan 8, 2015 · 12 comments

Comments

@SecUpwN
Copy link
Member

SecUpwN commented Jan 8, 2015

Androids

Folks, I know we're currently piling up on Issues, sorry about that. But trust me, this is good since this conveys we're having very clear ideas about how our App shall work and what needs to be addressed.

Since our project has set a high goal to provide broad support for current consumer smartphones out there, it is important to verify to the user if our App is really working as supposed to on their specific phone. Of course, we currently have our Requirements, but I do want to avoid people thinking that our App works on their new smartphone while in fact it does nothing else than showing a green Status Icon.

Proposal:

  • On initial startup of the App, run a set of tests to verify that the phone supports detection/protection
  • Show a prompt that gives exact detection information (maybe automatically create a logcat on SD)
  • If a users phone is not supported, tell user to join our GitHub and upload the logged information
  • Users shall be re-run it again by pressing Verify Detection/Protection from Preferences

Should this Issue be in fact a duplicate of #173 (which was declined here), let me know.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@E3V3A
Copy link
Contributor

E3V3A commented Jan 20, 2015

Maybe change the title of this one? It's very ambiguous to know what you mean with "Phone Support". That sound like a completely different thing to me...

@SecUpwN
Copy link
Member Author

SecUpwN commented Jan 20, 2015

@E3V3A, what is very ambiguous with it? Since we have set our goal to support as many phones as possible, we should add a prompt as proposed here that shows the user if his phone is indeed making use of all detection functions of our App, or if there is stuff missing. How would they know otherwise?

@E3V3A
Copy link
Contributor

E3V3A commented Jan 20, 2015

I agree completely, but I was just saying that "Phone Support" is usually understood as a place to call for support, and that's not what you meant. In addition we might wanna add that it should be an initial event that runs automatically on first start/install and then can be run manually from about page or something...

@SecUpwN SecUpwN changed the title Testing & Prompting Phone Support Initial Startup: Verify Detection & Protection Jan 20, 2015
@SecUpwN
Copy link
Member Author

SecUpwN commented May 22, 2015

I have been re-thinking this Issue and would now like @banjaxbanjo and @DimaKoz to have a word in here: Is it even a good idea running a small set of tests when initially installing our app to make sure it works properly? If it does not work and/or is not a good proposal, I might as well close this. Thanks.

  • Update: Since noone seems to care, what do you think @DJaeger? Could or should we even implement some short sequence of checks that are being run at initial start to tell the user what works and what doesn't with his specific device? I was thinking about some prompt saying something like Testing... then displaying the results. This could possibly be done during HowTo on first launch of AIMSICD #181.

@TPS
Copy link

TPS commented Jul 7, 2015

Since you're calling for more general comments, & since I'm a bit more "user"-level than most everyone here (& sorry in advance if my 2¢ is irrelevant =), I think this is a fantastic idea, given excellent heuristics, especially re: my trouble with #457 .

@marvinmarnold
Copy link
Contributor

Hi sorry for jumping in very late too. I think this is a tremendously good idea. Unfortunately, I'm not very sure how to implement it. Does anybody know how complex it might be?

@SecUpwN
Copy link
Member Author

SecUpwN commented Sep 20, 2015

Does anybody know how complex it might be?

Thanks for jumping in, @marvinmarnold. I know that our project seemed "dead" the past few weeks, I'm working hard to catch up again. My initial thought was to basically quickly test the functions of the phone where our app is installed on, all of this could be done during initial setup in #181, I guess. @DJaeger, are you able to tell us how the things proposed in here could be accomplished without writing a huge code-overload? Not sure if there exist any scripts or Android routines for tasks like this.

@marvinmarnold
Copy link
Contributor

What functions specifically would need to be tested? I'm going to two conferences soon (ARIN 36 & ITU World Telecom) that I want to have AIMSICD running during. I'm not even really sure if my phone is compatible at this point.

@DJaeger
Copy link
Collaborator

DJaeger commented Oct 14, 2015

Its a while since I had time to look at the current code, but last time the most of the tests, what is available to the app, were at the places the features were used.
There is currently no central place, where we check them and remain on these results.
Because of that we also do some tests multiple times, like if we use the GSM or CDMA classes.
We should "outsource" the tests in a feature detection class and use the results in all other classes.
And this class could also be used for this initial check.

@agilob
Copy link
Contributor

agilob commented Oct 14, 2015

@DJaeger
Copy link
Collaborator

DJaeger commented Oct 14, 2015

I mean for example a simply IF condition if the CDMA class of the TelephonyManager is available.
Or some types of switch statements to determine, what feature is available and can be used.

@SecUpwN
Copy link
Member Author

SecUpwN commented Dec 15, 2015

@larsgrefer, do you have any good ideas how we can implement a functionality test so that the user of our app knows which functions will work on his specific device? This test should be done during #181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants