Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobufjs v7.3.3 removed dist directory causing Cesium build to fail when resolving protobufjs/dist directory #12143

Closed
stevethewright opened this issue Aug 22, 2024 · 4 comments

Comments

@stevethewright
Copy link

What happened?

Version 7.3.3 has removed the dist directory causing Cesium to fail in the build process. This happened in v7.3.1 and a similar issue was created here (#12034). v7.3.2 brought back the dist folder and that issue was ignored.

✘ [ERROR] Could not resolve "protobufjs/dist/minimal/protobuf.js"
 node_modules/@cesium/engine/Source/Core/GoogleEarthEnterpriseMetadata.js:1:26:
 1 │ import * as protobuf from "protobufjs/dist/minimal/protobuf.js";

This can be fixed by manually installing v7.3.2.

As suggested in the previous issue, it would be ideal to lock the protobufjs version, especially since this happened a second time.

Reproduction steps

  1. Update/install latest cesium version with v7.3.3 of protobufjs.
  2. Build. (vite)
  3. Error is shown.

Sandcastle example

No response

Environment

Browser: Firefox 129.0.2
CesiumJS Version: 1.120.0
Operating System: Ubuntu 22.04

@stevethewright stevethewright changed the title protobufjs v7.3.3 removed dist directory protobufjs v7.3.3 removed dist directory causing Cesium build to fail when resolving protobufjs/dist directory Aug 22, 2024
@sincely
Copy link

sincely commented Aug 22, 2024

I aslo hava some question !!!!!!!!!

@ggetz
Copy link
Contributor

ggetz commented Aug 22, 2024

Thanks for bringing this up @stevethewright. We'll lock the working version of protobufjs in package.json.

@ggetz
Copy link
Contributor

ggetz commented Aug 22, 2024

Opened protobufjs/protobuf.js#2022.

@ggetz ggetz mentioned this issue Aug 22, 2024
6 tasks
@jjspace
Copy link
Contributor

jjspace commented Aug 23, 2024

protobuf already released an updated version including the dist directory again so I'm going to close this protobufjs/protobuf.js#2023

Please update your npm packages

@jjspace jjspace closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants