Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: send on closed channel in block import notifier #1701

Closed
noot opened this issue Jul 21, 2021 · 1 comment · Fixed by #1736
Closed

panic: send on closed channel in block import notifier #1701

noot opened this issue Jul 21, 2021 · 1 comment · Fixed by #1736
Assignees

Comments

@noot
Copy link
Contributor

noot commented Jul 21, 2021

Describe the bug

Occasionally when running the node I've seen this panic, causing the node to crash:

panic: send on closed channel

goroutine 56677 [running]:
github.com/ChainSafe/gossamer/dot/state.(*BlockState).notifyImported.func1(0xc005da4120, 0xc005f02780)
	/home/ubuntu/gossamer/dot/state/block_notify.go:107 +0x3f
created by github.com/ChainSafe/gossamer/dot/state.(*BlockState).notifyImported
	/home/ubuntu/gossamer/dot/state/block_notify.go:105 +0x1ae

need to make sure there are no writes to channels that are potentially closed

To Reproduce

Steps to reproduce the behaviour:

This happens quite infrequently, so not sure how to reproduce it other than running the node a bunch of times

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants