Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/telemetry: retry connection if there's an error #1862

Closed
noot opened this issue Oct 8, 2021 · 3 comments · Fixed by #1904
Closed

dot/telemetry: retry connection if there's an error #1862

noot opened this issue Oct 8, 2021 · 3 comments · Fixed by #1904

Comments

@noot
Copy link
Contributor

noot commented Oct 8, 2021

Task summary

  • in dot/telemetry/AddConnections(), if there is an error connecting to an endpoint, we just log the error and move on
  • we should probably retry to reconnect up to some maxRetries, then if they all fail, then log the error and move on
@zhuber6
Copy link
Contributor

zhuber6 commented Oct 11, 2021

Hi, do you want to have a delay in between retries? Or is there a timeout that can be used for the connection instead of retrying?

@noot
Copy link
Contributor Author

noot commented Oct 12, 2021

hey @zjhuber , a delay between retries is fine!

@zhuber6 zhuber6 mentioned this issue Oct 16, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dot/telemetry): Added connection retry zhuber6/gossamer
3 participants
@danforbes @noot @zhuber6