gossamer should not ban other gossamer nodes

[noot]

Task summary

• on the devnet, if you add a log in the peerset reportPeer function to check if a peer reaches the BannedThresholdValue, you will see that this ends up happening quite often.
• gossamer should not be banning other gossamer nodes, so either there is an issue with the scoring, or gossamer nodes are performing some "bad" behaviour that needs to be fixed

[timwu20]

Was unable to reproduce this issue on current development branch. Block production fails after the epoch transition. The actual epoch varies from run to run. Will pick this back up after @noot finishes her refactor of BABE.

[kishansagathiya]

Was able to replicate this in one of my branches. I saw some 3009 negative reputation changes, out of which 2851 were because of duplicate gossip messages.
I believe making sure we don't send duplicate gossip message could fix this problem. On it.

[kishansagathiya]

Some common negative peer reward

2022-03-18T17:12:17+05:30 DBUG reporting reputation change of -1024 to peer 12D3KooWH1cgFi2PkehEH2sHtkx7eQDkyyk3JikpvVNZqTRsoWv3, reason: Request timeout	handler.go:L81	pkg=peerset

frequency 33

2022-03-18T17:12:07+05:30 DBUG reporting reputation change of -4 to peer 12D3KooWH1cgFi2PkehEH2sHtkx7eQDkyyk3JikpvVNZqTRsoWv3, reason: Duplicate gossip	handler.go:L81	pkg=peerset

frequency 3009

2022-03-18T17:12:09+05:30 DBUG reporting reputation change of -2147483648 to peer 12D3KooWFgz1t6FUAFDMYwUjHdcZn3Td1Lts19sS5SaBX9q6DLMn, reason: Unsupported protocol	handler.go:L81	pkg=peerset

frequency 6

The message of banned threshold is coming right after negative rewards by unsupported protocol, which makes sense. bunch such negative reward could easily get the peer below banned threshold.

[kishansagathiya]

So, I am seeing that sometime we fail to check if /paritytech/grandpa/1 protocol is supported and sometimes we find that it is not supported, but protocol /paritytech/grandpa/1 is not supported by peer is lot more common

[kishansagathiya]

I can replicate this on development as well with a 4 node network.