Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load p2p protocolPrefix, bootNodes from genesis #228

Closed
noot opened this issue Aug 19, 2019 · 1 comment · Fixed by #369
Closed

load p2p protocolPrefix, bootNodes from genesis #228

noot opened this issue Aug 19, 2019 · 1 comment · Fixed by #369
Assignees

Comments

@noot
Copy link
Contributor

noot commented Aug 19, 2019

it's just a const right now, it should be passed into p2p through a config since different networks will have different prefixes.

solution: add protocolPrefix to config in p2p section, parse that and set it as the service.ProtocolPrefix when starting the new p2p service.

in the future: maybe we will need multiple prefixes. add functionality to allow for an array of supported prefixes

@noot noot self-assigned this Aug 19, 2019
@ansermino
Copy link
Member

This should probably be part of genesis config

@noot noot assigned noot and unassigned noot Sep 26, 2019
@noot noot changed the title put p2p protocolPrefix into config load p2p protocolPrefix, bootNodes from genesis Oct 2, 2019
@noot noot closed this as completed in #369 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants