Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot/state/pruner: refactor code to be more understandable and modular #2835

Closed
qdm12 opened this issue Sep 15, 2022 · 3 comments
Closed

dot/state/pruner: refactor code to be more understandable and modular #2835

qdm12 opened this issue Sep 15, 2022 · 3 comments
Labels
P-low this is mostly nice to have. T-enhancement this issue/pr covers improvement of existing functionality.

Comments

@qdm12
Copy link
Contributor

qdm12 commented Sep 15, 2022

The pruner code is (unit, integration and even usage-wise) untested, and hard to understand.

Since the trie lazy loading of nodes will interact a lot more with the database, and that the pruner already does some work with pruning database keys (node hashes), it feels required to understand the online pruner code and make it more modular.

@timwu20
Copy link
Contributor

timwu20 commented Nov 30, 2023

For context, we have disabled the online pruner in gossamer. Maybe something to work on after implementing the lazy loaded trie @dimartiro.

@timwu20
Copy link
Contributor

timwu20 commented Nov 30, 2023

I would characterize this issue as an optimization not required to achieve any of the current milestones.

@P1sar P1sar added T-enhancement this issue/pr covers improvement of existing functionality. P-low this is mostly nice to have. and removed state labels Jan 15, 2024
@timwu20
Copy link
Contributor

timwu20 commented Jun 19, 2024

Already being handled in the StateDB Optimizations epic.

@timwu20 timwu20 closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low this is mostly nice to have. T-enhancement this issue/pr covers improvement of existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants