Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/runtime: remove outdated/unneeded runtimes in constants.go #3087

Closed
EclesioMeloJunior opened this issue Jan 31, 2023 · 0 comments
Closed

lib/runtime: remove outdated/unneeded runtimes in constants.go #3087

EclesioMeloJunior opened this issue Jan 31, 2023 · 0 comments

Comments

@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Jan 31, 2023 •
edited
Loading

Description

Currently, in lib/runtime there is a file constants.go where we define some runtime names and URLs which is used for testing purposes.

It is important to make our codebase concise and in order to address the epic #2895, we should remove all outdated and unneeded runtimes, for example:

  • NODE_RUNTIME is a modified runtime generated using version 0.9 and placed in github.com/noot/substrate/blob/noot/v0.9 which should not be used for testing since it is outdated
@EclesioMeloJunior EclesioMeloJunior changed the title lib/runtime: remove outdated/uneeded runtimes in contants.go lib/runtime: remove outdated/unneeded runtimes in constants.go Jan 31, 2023
This was referenced Mar 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dimartiro @danforbes @EclesioMeloJunior