You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we should probably not remove the [32]byte and common.Hash cases, I believe some common types depend on these cases. also, you would think those two cases are duplicates, since common.Hash is an alias for [32]byte, but unfortunately the type switch doesn't recognize that :/
There seems to be some obvious cases missing from the codec test suite. Notably the following lines are never hit, some of which may be removable:
Encoding [32]byte:
gossamer/codec/encode.go
Lines 49 to 50 in 8fefce8
Encoding common.Hash (this may be removable, custom type should be implicitly handled)
gossamer/codec/encode.go
Lines 59 to 60 in 8fefce8
Encoding [][]byte:
gossamer/codec/encode.go
Lines 291 to 298 in 8fefce8
Decoding [32]byte, common.Hash (common.Hash likely removable):
gossamer/codec/decode.go
Lines 65 to 68 in 8fefce8
Decoding Interface whose value's kind is Slice or Array; kind is Struct:
gossamer/codec/decode.go
Lines 293 to 294 in 8fefce8
gossamer/codec/decode.go
Lines 300 to 301 in 8fefce8
Decoding Array Pointer:
gossamer/codec/decode.go
Lines 310 to 311 in 8fefce8
Decoding Tuple (not pointer):
gossamer/codec/decode.go
Lines 375 to 376 in 8fefce8
The text was updated successfully, but these errors were encountered: