Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GET validators api calls with POST api where possible #6831

Open
nflaig opened this issue May 30, 2024 · 0 comments · May be fixed by #6897
Open

Replace GET validators api calls with POST api where possible #6831

nflaig opened this issue May 30, 2024 · 0 comments · May be fixed by #6897

Comments

@nflaig
Copy link
Member

nflaig commented May 30, 2024

We might wanna start using the postStateValidators api instead of getStateValidators to avoid issues such as #6830.

This should be pretty safe to change this in CLI commands such as voluntary exit as users will likely interact with a Lodestar BN which implements the api

const res = await client.beacon.getStateValidators("head", {id: pubkeys});

We could also consider doing it in indicies store but need to ensure all other CL clients support the api (maybe switch after electra)

const res = await this.api.beacon.getStateValidators("head", {id: pubkeysHex});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant