Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Number value literal lookahead restrictions #944

Closed
michaelstaib opened this issue Aug 1, 2019 · 3 comments · Fixed by #6823
Closed

Add Number value literal lookahead restrictions #944

michaelstaib opened this issue Aug 1, 2019 · 3 comments · Fixed by #6823
Assignees
@michaelstaib
Labels
🌶️ hot chocolate 📌 pinned 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. ⚖️ spec Implement or fix a GraphQL specification item.
Milestone
Backlog

Comments

@michaelstaib
Copy link
Member

Update the Utf8GraphQLReader (lexer) to correctly distinguish between name, int and float tokens.

https://github.com/ChilliCream/hotchocolate/blob/master/src/Core/Language/Utf8/Utf8GraphQLReader.cs

Follow RFC over at the spec repo:
graphql/graphql-spec#601
@michaelstaib michaelstaib added the 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. label Aug 1, 2019
@michaelstaib michaelstaib added this to the 11.0.0 milestone Aug 1, 2019
@michaelstaib michaelstaib self-assigned this Aug 1, 2019
@michaelstaib
Copy link
Member Author

This is where we should do a look ahead:
https://github.com/ChilliCream/hotchocolate/blob/090a84bc9271e2a1bee67f9f22755dd84e4c18c7/src/Core/Language/Utf8/Utf8GraphQLReader.cs#L256

@michaelstaib
Copy link
Member Author

graphql/graphql-spec#599

@michaelstaib
Copy link
Member Author

graphql/graphql-spec#601

@michaelstaib michaelstaib added the ⚖️ spec Implement or fix a GraphQL specification item. label Nov 9, 2019
@michaelstaib michaelstaib modified the milestones: HC-11.x.x, Backlog Mar 31, 2021
@tobias-tengler tobias-tengler added the ⌛ stale Nothing happened with this issue in quite a while label Mar 15, 2022
@michaelstaib michaelstaib added 📌 pinned and removed ⌛ stale Nothing happened with this issue in quite a while labels May 4, 2022
@AntonC9018 AntonC9018 mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelstaib michaelstaib

Labels
🌶️ hot chocolate 📌 pinned 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. ⚖️ spec Implement or fix a GraphQL specification item.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add Number value literal lookahead restrictions ChilliCream/graphql-platform
2 participants
@michaelstaib @tobias-tengler