Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Latest Version of Browsers in Image #60

Closed
bruschke opened this issue Sep 1, 2021 · 1 comment
Closed

Include Latest Version of Browsers in Image #60

bruschke opened this issue Sep 1, 2021 · 1 comment

Comments

@bruschke
Copy link

bruschke commented Sep 1, 2021

Would it be possible to include the latest stable versions of the browsers supported by the browser-tools-orb in the -browsers images? This would allow us to avoid having to install them with each run when we are needing to run tests with Selenium. Additionally, it would solve the problem that many of us are currently facing with the Chrome install and Google apparently blocking requests. CircleCI-Public/browser-tools-orb#34

Lastly, there is a typo in the README.md should be -browsers not -browser.

@BytesGuy
Copy link
Contributor

BytesGuy commented Dec 9, 2021

Hi! Thanks for opening this issue.

Regarding the browsers, we intentionally do not install these in the images themselves. This would add extra size to the image itself and we would be limited to installing the latest version of browsers that are available at build time - this can quickly become out of date and may additionally not be the versions required by the end user. By installing them via the orb, the end user has greater control over the environment.

There is an open issue, linked below, to add a warning/documentation around this:

CircleCI-Public/cimg-shared#34

It looks like the linked issue for the browser tools orb was solved on the same day. Another possibility for avoid using the browser tools orb would be to spin a custom docker image using this image as a base. From there you could install the browsers you need so they are configured as required by your jobs.

The readme typo is fixed here, thanks for pointing this out 😄 #64

I hope this helps! I will close this issue out, but if you have any further comments please just let us know here and re-open the issue if required. Thanks!

@BytesGuy BytesGuy closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants