Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the help dialog box scrollable and switch to using tabs #70

Closed
3 tasks
ClementTsang opened this issue Mar 6, 2020 · 1 comment
Closed
3 tasks
Labels
feature Requests for a new feature.

Comments

@ClementTsang
Copy link
Owner

ClementTsang commented Mar 6, 2020

Describe the feature request

Why should we consider this feature request? Describe why, and/or how you think this feature will solve the issue, or overall improve the application:

EDIT: now two parts:

  1. Since help can wrap and entry size can go on for a bit, making it scrollable would solve the issue of potentially overflowing.

  2. More of an addendum since we're going to work with the dialog box anyways. tui-rs comes with tabs; we can use that to our advantage instead of our current tab system.

Additional context/details

Provide any additional context or details here. What needs to be done, why, etc:

A good example of how to do the scrolling this is ncdu. The procedure would probably be as follows:

  • Add a scroll state to app state. This doesn't have to use the bar system we use on others, we can just read it like a ticker tape (up and down scroll up/down how much is seen regardless, no bar

  • Canvas will ofc need to display this somehow. Use arrows to display (and hide if at border).

  • May need to play around with canvas widths too in the end.

In regards to tabs, this is more of a side suggestion.

@ClementTsang ClementTsang added the feature Requests for a new feature. label Mar 6, 2020
@ClementTsang ClementTsang changed the title Make the help dialog box scrollable Make the help dialog box scrollable and switch to using tabs Mar 8, 2020
@ClementTsang
Copy link
Owner Author

Solved by #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant