Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary date checking #1294

Open
handgunman opened this issue May 9, 2024 · 1 comment
Open

unnecessary date checking #1294

handgunman opened this issue May 9, 2024 · 1 comment

Comments

@handgunman
Copy link

This module does a check that is not needed.

func (e *DateOverflowError) Error() string {

Clickhouse allows insertion of data earlier than 1900. A conversion to the minimum date for the field type is performed.

https://fiddle.clickhouse.com/fa9e74d6-f107-4d0f-8446-04974d5f6f11

Moreover, a similar check is not performed for the field type Date.

@gogingersnap777
Copy link
Contributor

@jkaflik I believe the linked PR removes the unnecessary checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants