Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std/signature/eddsa is unnecessary complicated #262

Closed
gbotrel opened this issue Feb 15, 2022 · 0 comments · Fixed by #285
Closed

std/signature/eddsa is unnecessary complicated #262

gbotrel opened this issue Feb 15, 2022 · 0 comments · Fixed by #285
Labels
question Further information is requested
Milestone
v0.7.0

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 15, 2022

Currently we force the circuit developer to instantiate the twisted edwards curve

circuit.PublicKey.Curve, _ = twistededwards.NewEdCurve(api.Curve())
eddsa.Verify(api, circuit.Signature, circuit.Message, circuit.PublicKey)
  1. It should not be inside the eddsa.PublicKey structure
  2. It should probably be done behind eddsa.Verify

--> only new parameter is that we now support bandersnatch; so for BLS12-381 we may have multiple twisted edwards curves.
@gbotrel gbotrel added the question Further information is requested label Feb 15, 2022
@gbotrel gbotrel mentioned this issue Mar 9, 2022
Merged
@gbotrel gbotrel added this to the v0.7.0 milestone Mar 10, 2022
@gbotrel gbotrel mentioned this issue Mar 18, 2022
Merged
@gbotrel gbotrel linked a pull request Mar 18, 2022 that will close this issue
refactor: eddsa factorizing and code cleaning #285
Merged
@gbotrel gbotrel closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

refactor: eddsa factorizing and code cleaning Consensys/gnark
1 participant
@gbotrel