Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Put an option with/without sound for notification // limit notification to once per cleanup. #1508

Open
1 task done
Dorjaa opened this issue Mar 19, 2023 · 6 comments
Labels
browserbug/limitation Currently not fixable due to browser API limitations Feature Request

Comments

@Dorjaa
Copy link

Dorjaa commented Mar 19, 2023

Acknowledgements

  • I acknowledge that I have read the above items

Is your feature request related to a problem? Please describe.

I am still surprised and annoyed by the notification sound with the delete cookies popup.

Describe the solution that you'd like

In settings, extension options, provide a checkbox for "with/without" the sound of the notification.

Describe alternatives you've considered

No response

Additional Context

No response

@kennethtran93 kennethtran93 added the browserbug/limitation Currently not fixable due to browser API limitations label Mar 19, 2023
@kennethtran93
Copy link
Member

Unfortunately, we have no control over the notification sounds through the notifications API.

@ViroMad
Copy link

ViroMad commented Mar 19, 2023

Right now it chimes 3 times for me with a minor delay between each time. It started chiming 3 times instead of once when I enabled 'Other Browsing Data Cleanup Options'. Is it possible to limit the notifications to once?

@kennethtran93
Copy link
Member

Right now it chimes 3 times for me with a minor delay between each time. It started chiming 3 times instead of once when I enabled 'Other Browsing Data Cleanup Options'. Is it possible to limit the notifications to once?

Currently, there's one notification for cookie cleanup and one for any other browsing site data cleanups. Perhaps I can look to merge them into one, though by doing that, the notifications would be more generic as well due to limited space available for content.

@ViroMad
Copy link

ViroMad commented Mar 20, 2023

Your right I meant to say 2 but I hit 3.
Can the single notification mention as much as it can in one notification but, have a link to show more. So if I want to see more I can hover the mouse over it before it fades away(preventing it from doing so?) and I can click the link to see the log.

@kennethtran93
Copy link
Member

Your right I meant to say 2 but I hit 3. Can the single notification mention as much as it can in one notification but, have a link to show more. So if I want to see more I can hover the mouse over it before it fades away(preventing it from doing so?) and I can click the link to see the log.

As there isn't really a hardcoded limit of characters, I cannot determine when the notification would get truncated as it would vary per OS/device. While I can listen for click event on the notification itself (which could open up a new tab with the cleanup logs), there isn't anything to detect if the mouse is hovering over it (thus no way of stopping the timeout from automatically closing it).

@kennethtran93 kennethtran93 changed the title [FEATURE REQUEST] Put an option with/without sound for notification ??? [FEATURE REQUEST] Put an option with/without sound for notification // limit notification to once. May 13, 2023
@kennethtran93 kennethtran93 changed the title [FEATURE REQUEST] Put an option with/without sound for notification // limit notification to once. [FEATURE REQUEST] Put an option with/without sound for notification // limit notification to once per cleanup. May 13, 2023
@kennethtran93
Copy link
Member

kennethtran93 commented May 13, 2023

Firefox updated its notifications to use native system notifications as of Firefox 111. We have no control how notifications are generated after we send it off through the webextension API.

As such, you now have to make a choice

  • keep using the native system notifications (which also shows in the action center for the predefined time)
    • You'll need to go to your system settings and mute all notifications from Firefox then.
  • Switch back to the old Firefox notifications
    • requires tweaking about:config yourself: search for alerts.useSystemBackend and change to false

With this, of course, you lose the ability to see any notification history in your system notifications (not as much as other extensions as this has a delay set to close them at a preconfigured time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browserbug/limitation Currently not fixable due to browser API limitations Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants