Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parity-wasm with wasmparser for static checks #1735

Closed
webmaster128 opened this issue Jun 19, 2023 · 2 comments · Fixed by #1786
Closed

Replace parity-wasm with wasmparser for static checks #1735

webmaster128 opened this issue Jun 19, 2023 · 2 comments · Fixed by #1786
Milestone
1.4.0

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jun 19, 2023 •
edited
Loading

To solve #1727

See https://crates.io/crates/wasmparser. This is in our dependency tree already via Wasmer and folks seem to recommend it.
@webmaster128 webmaster128 added this to the 1.3.0 milestone Jun 19, 2023
@webmaster128 webmaster128 self-assigned this Jun 22, 2023
@webmaster128
Copy link
Member Author

parity-wasm allows the sign extension via a feature. However, the crate is unmaintained and should still be replaced.

@webmaster128 webmaster128 modified the milestones: 1.3.0, 1.4.0 Jun 22, 2023
@webmaster128
Copy link
Member Author

This requires #1742 to be adopted. Otherwise subtle changes in the Wasm valiation might lead to rejecting Wasm blobs that are in use on a chain for a long time.

@webmaster128 webmaster128 removed their assignment Jun 28, 2023
@chipshort chipshort mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Use wasmparser instead of parity-wasm CosmWasm/cosmwasm
1 participant
@webmaster128