Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cw3-flex/fixed-multisig] Status changes after voting and proposal expiration #630

Closed
maurolacy opened this issue Jan 12, 2022 · 2 comments · Fixed by #643
Closed

[cw3-flex/fixed-multisig] Status changes after voting and proposal expiration #630

maurolacy opened this issue Jan 12, 2022 · 2 comments · Fixed by #643
Assignees
@uint

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Jan 12, 2022 •
edited
Loading

A number of bugs were discovered in voting contracts, part of soon to be open-sourced poe-contracts. (See #12, #14, and #16).

Let's backport / adapt the fixes and tests to cw3-flex-multisig and cw3-fixed-multisig (if applicable).
@maurolacy maurolacy mentioned this issue Jan 12, 2022
Closed
@maurolacy maurolacy changed the title [cw3-flex/fixed-multisig] Status changes after voting, and proposal expiration [cw3-flex/fixed-multisig] Status changes after voting and proposal expiration Jan 12, 2022
@mcn8
Copy link

mcn8 commented Jan 24, 2022

Would love to see this improvement

@maurolacy maurolacy self-assigned this Jan 28, 2022
@maurolacy maurolacy mentioned this issue Jan 31, 2022
Closed
@maurolacy maurolacy assigned uint and unassigned maurolacy Jan 31, 2022
@maurolacy
Copy link
Contributor Author

maurolacy commented Jan 31, 2022 •
edited
Loading

@uint will take care of this, and the follow-ups.

This involves adapting the relevant voting tests from poe-contracts, see them fail, and fix the issues.

Alternatively, this could be done by migrating the voting-contract multitests here. Now sure which is simpler. (your call, @uint)

@uint uint mentioned this issue Jan 31, 2022
Merged
@uint uint closed this as completed in #643 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uint uint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix status/execution bugs in flex-multisig CosmWasm/cw-plus
3 participants
@uint @mcn8 @maurolacy