Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a two-step role transfer at cw_controllers::Admin #790

Open
Silverse opened this issue Aug 31, 2022 · 3 comments
Open
Labels
new spec Request for a new spec

Comments

@Silverse
Copy link

Is there a reason for not implementing a two-step admin transfer at cw_controllers::Admin?

It seems to be a common recommendation among security firms to limit the chances of updating the owner/admin to an incorrect/typo address.

  1. Propose new admin, old admin retains privileges.
  2. Proposed admin accepts the role, role is actually transferred.
@ueco-jb
Copy link
Contributor

ueco-jb commented Sep 1, 2022

I think this is just an extra step on top of "simply" carefully checking address which you input.
It would have to come with mechanism to revert decision in case of a mistake.

@Silverse
Copy link
Author

Silverse commented Sep 1, 2022

Yes, being able to drop an existing proposal should be part of the flow too

@ethanfrey
Copy link
Member

I agree with this idea, but it is a different API.

Happy to include an "SafeAdmin" controller, that is like Admin, but has the two-step pattern. We need to document it and contracts can choose which one to use.

@uint uint added the new spec Request for a new spec label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new spec Request for a new spec
Projects
None yet
Development

No branches or pull requests

4 participants