Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MsgInstantiateContract.init_funds/MsgExecuteContract.sent_funds to just funds #423

Closed
webmaster128 opened this issue Mar 1, 2021 · 2 comments · Fixed by #429
Closed
Assignees
Labels
api breaking enhancement New feature or request
Milestone

Comments

@webmaster128
Copy link
Member

Both fields end up in the same structure in wasmvm, where the field name has been simplified to just funds over the last weeks. We should do that here too for consistentcy. This would also better reflect that both fields do the same thing.

@ethanfrey
Copy link
Member

Note this may break CosmJS - at least it would change the types in the generated ts-proto code. I guess the wire types will not change, so a version will produce tx compatible with both v0.15 and v0.16 wasmd?

@webmaster128
Copy link
Member Author

webmaster128 commented Mar 1, 2021

I guess the wire types will not change, so a version will produce tx compatible with both v0.15 and v0.16 wasmd?

Right. In SIGN_MODE_DIRECT this change is compatible. With legazy Amino JSON signing it is breaking.

@alpe alpe added enhancement New feature or request api breaking labels Mar 3, 2021
@alpe alpe self-assigned this Mar 3, 2021
@alpe alpe closed this as completed in #429 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants