Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply response on submessages can overwrite "caller" result #495

Closed
alpe opened this issue Apr 23, 2021 · 0 comments · Fixed by #502
Closed

Reply response on submessages can overwrite "caller" result #495

alpe opened this issue Apr 23, 2021 · 0 comments · Fixed by #502
Assignees
Milestone

Comments

@alpe
Copy link
Member

alpe commented Apr 23, 2021

Currently we use the result from the call to execute and other methods as result of the operation. This makes it complicated to return the contract address for example that is created by a submessage instantiation call.

To resolve this issue the Data in Response can optionally be overwritten by the reply Data.

if Data value is nil then it is ignored and the Data from the original execute call is used.
When empty or filled with binary data then it overwrites original response.
Attributes are appended to the original ones coming from execute.

More details:
https://github.com/CosmWasm/cosmwasm/pull/898/files#diff-dd0d039bdd2406cd229097a9fcb061900fd900c51e75931b59ac705ecfe421adR280

@alpe alpe added this to the v0.16.0 milestone Apr 23, 2021
@alpe alpe self-assigned this Apr 26, 2021
@alpe alpe closed this as completed in #502 Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant