Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent infinite gas consumption in simulation queries #670

Closed
alpe opened this issue Nov 9, 2021 · 1 comment · Fixed by #674
Closed

Prevent infinite gas consumption in simulation queries #670

alpe opened this issue Nov 9, 2021 · 1 comment · Fixed by #674

Comments

@alpe
Copy link
Member

alpe commented Nov 9, 2021 •
edited by webmaster128
Loading

  • configurable per node
  • default to block gas limit
  • must not affect consensus

After some deeper analysis and discussion on #655 in our internal discord with @ethanfrey and @webmaster128 ,
we decided on a new path to solve the root cause. Or what may was the the root cause from the original issue on T.
No further infos provided 🤷‍♂️
The problem described in #655 addresses only a subset of fraud scenarios as simulations run in the sdk with infinite gas
@alpe alpe mentioned this issue Nov 9, 2021
Closed
@alpe alpe added this to the v1.0.0 milestone Nov 9, 2021
@ethanfrey
Copy link
Member

good one

@alpe alpe mentioned this issue Nov 17, 2021
Merged
@alpe alpe closed this as completed in #674 Nov 17, 2021
@alpe alpe modified the milestones: v1.0.0, v0.21.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit simulation gas CosmWasm/wasmd
2 participants
@alpe @ethanfrey