We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore_metrics
#5759 added these examples to the openmetrics check conf.yaml:
# ignore_metrics: # - <IGNORED_METRIC_NAME> # - <PREFIX_*> # - <*_SUFFIX> # - <PREFIX_*_SUFFIX> # - <*_SUBSTRING_*>
However, the implementation uses fnmatch.translate (code here), which does not exactly work like the documentation says.
fnmatch.translate
For example, the ignore_metric PREFIX_* would match both:
ignore_metric
PREFIX_*
PREFIX_HELLO
THIS_IS_A_PREFIX_TOO
We came across this problem when trying to exclude high cardinality go_* metrics, while including argo_* metrics.
go_*
argo_*
Steps to reproduce the issue:
_*
_
Describe the results you expected:
We expected the documentation to be the expected behavior.
I suppose either the documentation should be fixed or the implementation.
The text was updated successfully, but these errors were encountered:
cc @ahmed-mez for visibility
Sorry, something went wrong.
Hey @omh1280 thanks for opening this issue, and sorry for the trouble!
Opened #9729 to address this. Thanks!
Successfully merging a pull request may close this issue.
#5759 added these examples to the openmetrics check conf.yaml:
However, the implementation uses
fnmatch.translate
(code here), which does not exactly work like the documentation says.For example, the
ignore_metric
PREFIX_*
would match both:PREFIX_HELLO
THIS_IS_A_PREFIX_TOO
We came across this problem when trying to exclude high cardinality
go_*
metrics, while includingargo_*
metrics.Steps to reproduce the issue:
ignore_metrics
in the openmetrics check to_*
and any metrics with_
in them (not just those that start with_
) will be ignored.Describe the results you expected:
We expected the documentation to be the expected behavior.
I suppose either the documentation should be fixed or the implementation.
The text was updated successfully, but these errors were encountered: