Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRC-575] [Bug] Advanced Diffs Return Errors in dbt-athena #392

Closed
tkrishna-equip opened this issue Jul 23, 2024 · 3 comments
Closed

[DRC-575] [Bug] Advanced Diffs Return Errors in dbt-athena #392

tkrishna-equip opened this issue Jul 23, 2024 · 3 comments
Labels
bug Something isn't working linear Created by Linear-GitHub Sync triage Triage required

Comments

@tkrishna-equip
Copy link

tkrishna-equip commented Jul 23, 2024

Current Behavior

All Advanced Diffs run for a long time and return errors

Expected Behavior

Advanced Diffs should run quickly and without errors

Steps To Reproduce

Configure this environment:
dbt core: version 1.6.15
dbt-athena: version 1.6.3
python: 3.9.6

Select Advanced Diffs and try running

Relevant log output

No response

Environment

  • recce: 0.20.0
  • OS: MacOS 14.5
  • Python: 3.9.6
  • Data Warehouse:
  • dbt: 1.6.15

Additional Context

image
image

DRC-575

@tkrishna-equip tkrishna-equip added bug Something isn't working triage Triage required labels Jul 23, 2024
@even-wei even-wei added the linear Created by Linear-GitHub Sync label Jul 25, 2024
@even-wei even-wei changed the title [Bug] Advanced Diffs Return Errors in dbt-athena [DRC-575] [Bug] Advanced Diffs Return Errors in dbt-athena Jul 25, 2024
@popcornylu
Copy link
Contributor

For value diff, it seems a issue from audit helper
dbt-labs/dbt-audit-helper#87

Please see the workaround solution a paste in the issue.

@popcornylu
Copy link
Contributor

popcornylu commented Aug 5, 2024

The problem for top-k and histogram, it is fixed in #395 and will be available at the next release. I will updated the release number here once it is releaased.

For valude diff and profile diff. I found that there are compatibility issues with audit-helper and dbt-profiler on AWS Athena.

Just created a PR in audit-helper
dbt-labs/dbt-audit-helper#108
and created a PR in dbt-profiler
data-mie/dbt-profiler#91
A current walk-around solution is to put
https://github.com/DataRecce/recce/blob/main/macros/recce_athena.sql in marcros folder of your dbt project.

@even-wei even-wei modified the milestone: 2024 W32 (v0.30) Aug 6, 2024
@popcornylu
Copy link
Contributor

The upstreams' PRs aren't merged. I close this issue first, please use the workaround solution mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linear Created by Linear-GitHub Sync triage Triage required
Projects
None yet
Development

No branches or pull requests

3 participants