Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a get_session() utility function #87

Open
jesper-friis opened this issue Nov 19, 2022 · 1 comment
Open

Add a get_session() utility function #87

jesper-friis opened this issue Nov 19, 2022 · 1 comment

Comments

@jesper-friis
Copy link
Contributor

Add a get_session() utility function and replace all current occurences of

AttrDict(**json.loads(raw_session))

with get_session(raw_session), where raw_session is what is returned by the fetch(), get() and initialize() methods.

This makes the code easier to read and makes it much easier to change the return value of the fetch(), get() and initialize() methods as suggested in issue #86.

If issue #86 is rejected, this utility function would still be improve the user-friendliness (although not as much as issue #86).

@CasperWA
Copy link
Contributor

I don't think this is relevant any longer? Issue #86 is being implemented by #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants