Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude isort for Python 3.7 #114

Open
jesper-friis opened this issue Jun 2, 2023 · 2 comments
Open

Exclude isort for Python 3.7 #114

jesper-friis opened this issue Jun 2, 2023 · 2 comments

Comments

@jesper-friis
Copy link
Contributor

jesper-friis commented Jun 2, 2023

We want tripper to support Python 3.7, but isort only supports Python 3.8+.

If possible, configure pre-commit to ignore isort if Python version < 3.8. An alternative is to run

export SKIP=isort

before running pre-commit for Python 3.7. That is probably the simplest. If you have a virtual environment, you could set (and reset) this in the activate script, so that you don't have to think about it.

If we go that this solution, this issue reduces to documenting that you have to set the SKIP environment variable for Python < 3.8.

@alfredoisg
Copy link
Contributor

Not sure whether it is worth focusing a lot on Python 3.7 given it is reaching its end-of-life this month.
See https://peps.python.org/pep-0537/#lifespan

@sygout
Copy link
Contributor

sygout commented Jun 12, 2023

Ok then Jesper could you confirm and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants