Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of DLQ via props #89

Closed
reisingerf opened this issue Mar 25, 2024 · 2 comments · Fixed by #93
Closed

Allow configuration of DLQ via props #89

reisingerf opened this issue Mar 25, 2024 · 2 comments · Fixed by #93
Assignees
Labels
enhancement New feature or request

Comments

@reisingerf
Copy link

Would it be possible to allow provisioning of DLQ properties similar to the main queue properties (or reuse props from the main queue)?

A simple use case: enforceSSL
This can be set for the monitored queue via the QueueProps, but is not passed on to the DLQ. Only option at the moment is to create a DLQ outside of the construct and provide that, which sort of defeats its purpose / usefulness.

Although the CDK defaults to false, from a security perspective enforcing SSL should perhaps even be the default.

Our use case can be found here.

@EYssel
Copy link
Owner

EYssel commented Mar 25, 2024

Hi @reisingerf,

Thanks for the feedback.

Am I correct in assuming that it would be useful if the following property is exposed as an optional way to customise your DLQ?:

{
   ...
   queueProps: QueueProps,
   dlqProps: QueueProps,
   ...
}

@reisingerf
Copy link
Author

Yes, I think that would solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
2 participants