Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin compatibility with WKWebView? #1098

Open
joaolori opened this issue May 1, 2020 · 3 comments
Open

Plugin compatibility with WKWebView? #1098

joaolori opened this issue May 1, 2020 · 3 comments

Comments

@joaolori
Copy link

joaolori commented May 1, 2020

Hello,

Is this plugin compatible with the new WKWebView webview engine?

Related with this: ionic-team/cordova-plugin-ionic-webview#559

Thanks

@tlacroix
Copy link

tlacroix commented May 1, 2020

Hi @joaolori,

I was asking myself the same question, and I found the answer below.
#1052

Short: it's been removed in 5.6.0+. If you look at the code, you will see that the block is commented out. Pretty sure that's enough for ITMS-90809.

- (NSString*)getIPadPopupCoordinates {
  // see https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052
  return nil;
  /*
  if (_popupCoordinates != nil) {
    return _popupCoordinates;
  }
  if ([self.webView respondsToSelector:@selector(stringByEvaluatingJavaScriptFromString:)]) {
    return [(UIWebView*)self.webView stringByEvaluatingJavaScriptFromString:@"window.plugins.socialsharing.iPadPopupCoordinates();"];
  } else {
    // prolly a wkwebview, ignoring for now
    return nil;
  }
  */
}

@EinfachHans
Copy link

I use this Plugin and have no Warning about ITMS-90809

@tanzanman
Copy link

Yes! I can confirm successful submission of an app today using this plugin at version 5.6.8. App uses WKWebview only along with this plugin and passed. It's really frustrating now that Apple no longer accepts app submissions if their code scanners sniff ITMS-90809 and you have to upload the binary to find that out. Thanks Eddy for your contributions here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants