Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path for php_cs file not properly quoted #184

Closed
auroraeosrose opened this issue Sep 13, 2019 · 2 comments
Closed

Path for php_cs file not properly quoted #184

auroraeosrose opened this issue Sep 13, 2019 · 2 comments

Comments

@auroraeosrose
Copy link

Related to fix for issue #180

The path passed to the command line is not properly quoted when passed to the command line, so if there are spaces in the path the tool will error

in .phpqa.yml

php-cs-fixer:
    config: .php_cs
    rules: '@PSR2'
    allowRiskyRules: false
    isDryRun: false
    verbose: true

Output

[Edge\QA\Task\ParallelExec] Output for "C:\xxxx/vendor/bin/php-cs-fixer" fix "./" --verbose --format junit --config C:\xxx\source\repos\Repo Name\tests\.php_cs:

 [Edge\QA\Task\ParallelExec]  In ConfigurationResolver.php line 570:                                                                      
 [PhpCsFixer\ConfigurationException\InvalidConfigurationException (16)]  
Cannot read config file "C:\xxx\source\repos\Repo"

I'm reverting back to a previous version of the tool for now since this is breaking my ci :(

@zdenekdrahos
Copy link
Member

Fixed in 1.23.1

@auroraeosrose
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants