Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP CS Fixer #60

Closed
keradus opened this issue Apr 22, 2017 · 4 comments · Fixed by #66
Closed

Support PHP CS Fixer #60

keradus opened this issue Apr 22, 2017 · 4 comments · Fixed by #66

Comments

@keradus
Copy link

keradus commented Apr 22, 2017

Hi.
Are there any chances that you would add PHP CS Fixer to collection of supported tools ?

@zdenekdrahos
Copy link
Member

How would you like to use php-cs-fixer in phpqa?

It can be added to suggested tools. But I have a doubt about usefulness. phpqa analyzes code. If you run analysis twice, you'll get the same result. php-cs-fixer isn't like that. It can fix code in CI build, but changes aren't committed. Wouldn't be better to install phpqa and php-cs-fixer separately?

@keradus
Copy link
Author

keradus commented Apr 23, 2017

in same way that phpcpd or phpmd or anything that is currently supported.
PHP CS Fixer could fix indeed, but it could also generate violations report.

@mastercoding
Copy link

@zdenekdrahos You are right that changing code style errors in the ci build does not make any sense. However, if php-cs-fixer is run with junit as output (optionally in "dry-run" mode, to not change anything and produce the same results every time), it is a static analyser just like phpcs.

@zdenekdrahos
Copy link
Member

Ok. php-cs-fixer gonna be in the next release.
I'll ask you for your review in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants