Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sun's center has a darker spot in reflections #63

Open
SeppahBaws opened this issue Jul 10, 2022 · 0 comments
Open

The sun's center has a darker spot in reflections #63

SeppahBaws opened this issue Jul 10, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@SeppahBaws
Copy link

SeppahBaws commented Jul 10, 2022

Describe the bug
When looking at the sun through a reflection, the sun's center has a black pixel. After attaching Nsight, I saw that the light_gbuffer.hlsl shader outputs inf for the pixel in the center of the sun's reflection.

I 'fixed' it by clamping the shader output between zero and a large value, but I don't properly understand all the PBR shader code so I don't know a more correct way of fixing it.

To Reproduce

  1. Go to this commit on main: 6145eaa (the latest at the time of submitting this bug report)
  2. Load a model with a mirror-like reflective surface (I used the car.ron scene)
  3. Rotate the sun so that it's visible in the reflection
  4. The sun has a dark spot in the center.

Expected behavior
The sun's center should not have a darker spot like that.

Screenshots
image
image

Device:

  • OS: Windows 11
  • OS version: 21H2 build 22000.739
  • GPU: 3080 Ti
  • GPU driver version: 516.59
  • rust version: rustc 1.64.0-nightly (ddcbba036 2022-06-29)
  • cargo version: cargo 1.64.0-nightly (dbff32b27 2022-06-24)
@SeppahBaws SeppahBaws added the bug Something isn't working label Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant