Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark shader blockers #233

Closed
4 tasks done
fu5ha opened this issue Nov 12, 2020 · 4 comments
Closed
4 tasks done

Ark shader blockers #233

fu5ha opened this issue Nov 12, 2020 · 4 comments
Assignees
Labels
t: enhancement A new feature or improvement to an existing one.

Comments

@fu5ha
Copy link
Member

fu5ha commented Nov 12, 2020

@fu5ha fu5ha added the t: enhancement A new feature or improvement to an existing one. label Nov 12, 2020
@fu5ha fu5ha changed the title Ark shader blockers tracking issues Ark shader blockers Nov 12, 2020
@Jasper-Bekkers
Copy link
Contributor

Jasper-Bekkers commented Nov 30, 2020

  1. Running runners with release mode not working is a blocker as well, ends up in infinite loop fixed for now by using separate shader builder crate
  2. Subchecked is a problem in weird cases which is fucked for flags. zombie constants/types are merged with normal constants/types #274 fixed by Do not merge zombie and non-zombies #288
  3. Bindless arrays are seen as runtime arrays?
layout(set = 0, binding = 1) readonly buffer InstanceDataBuffer {
    InstanceDataEntry instance_data[];
};
  1. Missing nointerpolation attribute. (Needed for the flags on the mesh shader)
  2. Hacked in multiview capability would be nice? (Only needed for VR - but easy to add)

@khyperia
Copy link
Contributor

@fu5ha
Copy link
Member Author

fu5ha commented Dec 4, 2020

@khyperia added #314 to this because I think it's blocking for https://github.com/EmbarkStudios/ark/pull/2756 but not sure if that's actually true

@Jasper-Bekkers
Copy link
Contributor

I think we can close this now that most Ark shaders have migrated to rust-gpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: enhancement A new feature or improvement to an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants