Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect axiom annotation for ice #465

Closed
cmungall opened this issue Feb 20, 2017 · 1 comment
Closed

incorrect axiom annotation for ice #465

cmungall opened this issue Feb 20, 2017 · 1 comment
Assignees

Comments

@cmungall
Copy link
Member

current release file:

id: ENVO:01000277
name: water ice
def: "Ice is water frozen into a solid state. It can appear transparent or opaque bluish-white color, depending on the presence of impurities or air inclusions. The addition of other materials such as soil may further alter its appearance." [https://en.wikipedia.org/wiki/Ice]
synonym: "ice" RELATED [http://www.eionet.europa.eu/gemet/concept/4131] {def="The dense substance formed by the freezing of water to the solid state; it commonly occurs in the form of hexagonal crystals. (Source: MGH)"}

this is causing some downstream issues. The syntax is actually valid but unexpected. It's caused by a definition axiom annotation on a synonym. This should be disallowed (ie structural violation, not syntactic). But for now we should do a fix. It's clear this was intended as the definition, but not clear which one is primary.

@cmungall
Copy link
Member Author

this one too

id: ENVO:01000537
name: atmospheric ozone
def: "Atmospheric ozone is an environmental material primarily composed of ozone in its gaseous form and present in the atmosphere." []
synonym: "atmospheric ozone" RELATED [http://www.eionet.europa.eu/gemet/concept/632] {def="A triatomic molecule of oxygen; a natural constituent of the atmosphere, with the highest concentrations in the ozone layer or stratosphere; it is found at a level between 15 and 30 km above the Earth, which prevents harmful ultraviolet B radiation, which causes skin cancer and threatens plant life, from reaching the ground. The fragile shield is being damaged by chemicals released on Earth. The main chemicals that are depleting stratospheric ozone are chlorofluorocarbons (CFCs), which are used in refrigerators, aerosols and as cleaners in many industries and halons, which are used in fire extinguishers. The damage is caused when these chemicals release highly reactive forms of chlorine and bromine. (Source: GILP96 / WRIGHT)"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants