Max FPS not honouring the URL parameter with 5.1 and not working at all with 5.0

[dan-tw]

On the settings panel under WebRTC there is a Max FPS setting. If value in the panel is changed, it appends a parameter to the URL e.g. http://localhost/?WebRTCFPS=30

Using UE 5.1

• Visiting the frontend URL with the ?WebRTCFPS=30 parameter does not update the Max FPS in the Information panel.
• Changing the Max FPS in the WebRTC section on the Settings panel does update the MaxFPS in the Information panel.

Using UE 5.0, Max FPS just does not seem to work at all

[Belchy06]

I've got an idea of what's happening with this one.

I think what's happening is we're setting the FPS to what ever is in the URL. Updating this does nothing as when first run we currently don't have a stream.

User starts a stream, and will receive the initial settings object which updates all of WebRTC and encoder settings.

The callbacks on these settings are set to send their new value to UE so we end up just setting them back to whatever the application send us in the first place.

[lukehb]

@MWillWallT Is this fixed now, I think it is?

[MWillWallT]

@lukehb I've tested this, unfortunately the issues are still present.
5.1 doesn't update the FPS in the info panel with the URL /?WebRTCFPS=30. As reported though changing it via the control panel does work. This was tested with the 5.1 Infra and latest 5.1.

I'm currently in the process of pulling 5.0 to test that.

[Belchy06]

It's a frontend specific issue. Will still happen with 5.0

[lukehb]

Is it fixed in the UE 5.2 branch of the infra. If so, we can backport.

[Belchy06]

This was tested using latest frontend version. Pretty sure we didn't support setting WebRTC settings in the URL with the old JS monolith, which is why it's popped up now.

[lukehb]

Fixed in 1695df2