From f472d6a4db9348affed1b473d45f6ddaa01ce6fa Mon Sep 17 00:00:00 2001 From: Michael Stopa Date: Wed, 26 Jul 2023 17:16:08 +0930 Subject: [PATCH 1/2] Properly inject new params into SDP to get stereo back on Chrome --- .../PeerConnectionController/PeerConnectionController.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts index 1ba096f8..247aabb8 100644 --- a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts +++ b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts @@ -207,16 +207,13 @@ export class PeerConnectionController { * @returns A modified Session Descriptor */ mungeSDP(sdp: string, useMic: boolean) { - const mungedSDP = sdp; - mungedSDP.replace( + let mungedSDP = sdp.replace( /(a=fmtp:\d+ .*level-asymmetry-allowed=.*)\r\n/gm, '$1;x-google-start-bitrate=10000;x-google-max-bitrate=100000\r\n' ); - let audioSDP = ''; - // set max bitrate to highest bitrate Opus supports - audioSDP += 'maxaveragebitrate=510000;'; + let audioSDP += 'maxaveragebitrate=510000;'; if (useMic) { // set the max capture rate to 48khz (so we can send high quality audio from mic) @@ -232,7 +229,7 @@ export class PeerConnectionController { audioSDP += 'useinbandfec=1'; // We use the line 'useinbandfec=1' (which Opus uses) to set our Opus specific audio parameters. - mungedSDP.replace('useinbandfec=1', audioSDP); + mungedSDP = mungedSDP.replace('useinbandfec=1', audioSDP); return mungedSDP; } From 8c4dff79533ea8c42f57f494061c998d065c3c65 Mon Sep 17 00:00:00 2001 From: Michael Stopa Date: Wed, 26 Jul 2023 17:40:13 +0930 Subject: [PATCH 2/2] Forgot to remove a sneaky little plus sign --- .../src/PeerConnectionController/PeerConnectionController.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts index 247aabb8..776562d1 100644 --- a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts +++ b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts @@ -213,7 +213,7 @@ export class PeerConnectionController { ); // set max bitrate to highest bitrate Opus supports - let audioSDP += 'maxaveragebitrate=510000;'; + let audioSDP = 'maxaveragebitrate=510000;'; if (useMic) { // set the max capture rate to 48khz (so we can send high quality audio from mic)