From 49392ac5f7ebab1285100b84b78c145c9f7ebaf3 Mon Sep 17 00:00:00 2001 From: Michael Stopa Date: Thu, 27 Jul 2023 09:32:26 +0930 Subject: [PATCH] Properly inject new params into SDP to get stereo back on Chrome (#332) (cherry picked from commit 1947760e2b6044be7ac7fa5d5af6925f2b165998) --- .../PeerConnectionController/PeerConnectionController.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts index 1ba096f8..776562d1 100644 --- a/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts +++ b/Frontend/library/src/PeerConnectionController/PeerConnectionController.ts @@ -207,16 +207,13 @@ export class PeerConnectionController { * @returns A modified Session Descriptor */ mungeSDP(sdp: string, useMic: boolean) { - const mungedSDP = sdp; - mungedSDP.replace( + let mungedSDP = sdp.replace( /(a=fmtp:\d+ .*level-asymmetry-allowed=.*)\r\n/gm, '$1;x-google-start-bitrate=10000;x-google-max-bitrate=100000\r\n' ); - let audioSDP = ''; - // set max bitrate to highest bitrate Opus supports - audioSDP += 'maxaveragebitrate=510000;'; + let audioSDP = 'maxaveragebitrate=510000;'; if (useMic) { // set the max capture rate to 48khz (so we can send high quality audio from mic) @@ -232,7 +229,7 @@ export class PeerConnectionController { audioSDP += 'useinbandfec=1'; // We use the line 'useinbandfec=1' (which Opus uses) to set our Opus specific audio parameters. - mungedSDP.replace('useinbandfec=1', audioSDP); + mungedSDP = mungedSDP.replace('useinbandfec=1', audioSDP); return mungedSDP; }