Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched join button hovering effect #335

Closed
MohamedHabarneh opened this issue Mar 12, 2022 · 2 comments
Closed

Mismatched join button hovering effect #335

MohamedHabarneh opened this issue Mar 12, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@MohamedHabarneh
Copy link
Collaborator

What happened?

website_button
website_button2

The hovering effect of the join button on the event's card is different than the rest of the buttons on the website. Keep in mind, that the color of the join button in the event card should be consistent with the ACM path.

@MohamedHabarneh MohamedHabarneh added the bug Something isn't working label Mar 12, 2022
@MohamedHabarneh MohamedHabarneh added this to the v3.0 🌞 milestone Mar 12, 2022
@EthanThatOneKid
Copy link
Owner

The hover effect on both these buttons are different. To keep things consistent, I think we should go with the hover effect where the text changes colors instead of the background-color of the button. This might be possible by consolidating the buttons seen in the two screenshots into a single, shared button component.

Decision reached by @anhduy1202, @EthanThatOneKid, and others via Discord

@anhduy1202
Copy link
Collaborator

PR: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants