Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Events: Create secondary list to display ACM_PINNED=true events #422

Closed
Tracked by #310
EthanThatOneKid opened this issue Apr 8, 2022 · 2 comments
Closed
Tracked by #310

Comments

@EthanThatOneKid
Copy link
Owner

EthanThatOneKid commented Apr 8, 2022

To create this secondary list of pinned events items, we must filter only AcmEvents where isPinned is true. To check if an Google Calendar event is intended to be pinned, we must check for an ACM_PINNED variable in the description. If that variable’s value is truthy, the event isPinned.

@EthanThatOneKid
Copy link
Owner Author

EthanThatOneKid commented Apr 12, 2022

We already check to see if a string is truthy in

// DEBUG flag is activated when anything besides '', '0', or 'false' is selected
export const DEBUG = !['', '0', 'false'].includes(String(import.meta.env.VITE_DEBUG).toLowerCase());

So, we can abstract that into a new utility function to be used in place above and again in makeAcmEvent to check if an event is pinned.

@jaasonw jaasonw linked a pull request Apr 29, 2022 that will close this issue
@EthanThatOneKid EthanThatOneKid removed a link to a pull request May 19, 2022
@EthanThatOneKid
Copy link
Owner Author

"Recent events" are not necessary to be showcased on the front events page of our website. Perhaps it would be more appropriate to dedicate a new page to recent events, or adding blog posts (with a past-event label) to recount the event.

Despite technically resolving this tracked issue in #477, I will close this issue since we are no longer interested in having this feature located on /events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant