Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-03-01] Create "Contact method" menu in Profile page & "Contact methods" page #15038

Closed
Beamanator opened this issue Feb 10, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Feb 10, 2023

Part of the bigger "Account Settings" project - https://github.com/Expensify/Expensify/issues/182122

This is part 1 of our plan, where we're breaking the process into 4 steps (see tracking issue ^)

Goals for this issue: Edit Profile page & put old LoginField in Contact methods page, skipping "add contact method" and everything else for now

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0194cea0cb70786833
  • Upwork Job ID: 1625777803769167872
  • Last Price Increase: 2023-03-07
@Beamanator Beamanator self-assigned this Feb 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 10, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Feb 10, 2023
@Beamanator
Copy link
Contributor Author

PR for this is here, and it's in review: #15039

Not exactly sure why the link preview didn't show in this issue 🤷

@Beamanator Beamanator added the Internal Requires API changes or must be handled by Expensify staff label Feb 15, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 15, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0194cea0cb70786833

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@Beamanator
Copy link
Contributor Author

Sorry @0xmiroslav - @Santhosh-Sellavel was already assigned as a C+ on the related PR

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 22, 2023
@melvin-bot melvin-bot bot changed the title Create "Contact method" menu in Profile page & "Contact methods" page [HOLD for payment 2023-03-01] Create "Contact method" menu in Profile page & "Contact methods" page Feb 22, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 22, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.75-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@MelvinBot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Daily KSv2 and removed Weekly KSv2 labels Feb 23, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@Beamanator Assign a BugZero here thanks!

@Beamanator Beamanator added Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Mar 7, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-03-01] Create "Contact method" menu in Profile page & "Contact methods" page [$1000] [HOLD for payment 2023-03-01] Create "Contact method" menu in Profile page & "Contact methods" page Mar 7, 2023
@MelvinBot
Copy link

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

@Beamanator Beamanator added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 7, 2023
@MelvinBot
Copy link

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot

This comment was marked as outdated.

@Beamanator Beamanator removed the Bug Something is broken. Auto assigns a BugZero manager. label Mar 7, 2023
@Beamanator
Copy link
Contributor Author

@slafortune added Bug label just to get you assigned! :D Please can you help pay out @Santhosh-Sellavel as the C+ on my internal PR?

@slafortune
Copy link
Contributor

@Santhosh-Sellavel has been paid now 👍

@slafortune
Copy link
Contributor

I think this is good to close now @Beamanator

@Beamanator

This comment was marked as off-topic.

@Beamanator

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor Author

Ohhhhhhhh my goodness I'm so sorry I'm confused, a different PR got reverted... Good to close!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants