Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-28] [$250] Migrate index.js to function component #16129

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 23 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

  • src/components/Composer/index.js
    • type: React.Component
    • has state values: true
    • has refs: true
    • has context: false
    • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@s-alves10
Copy link
Contributor

I'd love to work on this.

@GiovanniCaiazzo01
Copy link

hey I'd like to work on this task

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

📣 @GiovanniCaiazzo01! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@GiovanniCaiazzo01
Copy link

Contributor details
Your Expensify account email: giovannicaiazzo002@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01572883c97205ee25

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@perunt
Copy link
Contributor

perunt commented Jul 7, 2023

hey there, I'm currently developing the inline suggestion feature and this task is creating a bit of a hold-up for me. Could I jump in and expedite its completion?

@marcaaron marcaaron changed the title [HOLD][$250] Migrate index.js to function component [$250] Migrate index.js to function component Jul 7, 2023
@marcaaron marcaaron added the Weekly KSv2 label Jul 7, 2023
@rayane-djouah
Copy link
Contributor

I'd like to work on this issue

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket :)

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2023
@code0406
Copy link
Contributor

I am available to work on this.

@perunt perunt mentioned this issue Jul 26, 2023
58 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 Overdue labels Jul 27, 2023
@aditygrg2
Copy link

Hello, I would like to work on this issue.

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 17, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 17, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate index.js to function component [HOLD for payment 2023-08-28] [$250] Migrate index.js to function component Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @ArekChr does not require payment (Contractor)
  • @allroundexperts does not require payment (Eligible for Manual Requests)
  • @perunt does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 Overdue labels Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

@ArekChr, @allroundexperts, @perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@ArekChr, @allroundexperts, @perunt Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@ArekChr, @allroundexperts, @perunt 12 days overdue now... This issue's end is nigh!

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@ArekChr, @allroundexperts, @perunt 12 days overdue now... This issue's end is nigh!

@perunt
Copy link
Contributor

perunt commented Sep 11, 2023

It's already been merged and used in production. Can we close this ticket?

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

@ArekChr, @allroundexperts, @perunt Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@ArekChr, @allroundexperts, @perunt Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

@ArekChr, @allroundexperts, @perunt Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@perunt
Copy link
Contributor

perunt commented Sep 20, 2023

@mountiny, can we mark this issue as resolved? We've been using it in production for some time now, so I believe we can close it

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests