Reaction emoji disappears/reappears after quickly adding/removing reactions

[kavimuru]

Rollout Plan

• Support both existing and new emojiReactions data format in Auth #18427
• https://github.com/Expensify/Expensify/issues/281934
• [$1000] [HOLD for payment 2023-08-01] Support new emojiReactions in NewDot #19531
• Cleanup: Remove useEmojiReactions param from PHP #19529
• [HOLD App/issues/19529] Cleanup: Remove original "reactions" data format code in Auth #19534
• [HOLD App/issues/19534] Cleanup: Remove useEmojiReactions param from NewDot #19535

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat

2. Type a text

3. Long press and react to some emojis , Please do select 3 / 4 emojis ( using add emoji button)

4. Notice that you have now multiple emoji reactions on that typed text.

5. Now unselect those emojis

   Notice that after unselecting all emojis, they reappear

Expected Result:

After unselecting emojis, they should not reappear

Actual Result:

When all emojis are unselected, usually one or all emojis are restored. Further, if new text is typed below. Such restoration doesn’t last.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native ( Device model : one plus nord)
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.87-1
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Record_2023-03-24-21-51-04.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679675126743679

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e24bec63a2e084f
• Upwork Job ID: 1640357797486551040
• Last Price Increase: 2023-03-27

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016e24bec63a2e084f

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[stitesExpensify]

This is the same as number 3 from my slack post here https://expensify.slack.com/archives/C049HHMV9SM/p1678286500121729

I'll leave this open and assigned to me since we didn't have an issue for it, but it is known

[priyeshshah11]

@stitesExpensify Just FYI, this also happens when you add/remove reactions when offline & then go back online as it effectively is the same as reacting quickly as both requests will be sent in quick successions.

[laurenreidexpensify]

@stitesExpensify what is the latest on this one?

[stitesExpensify]

No update yet. This is a bug that is not specific to emojis and happens in other places like pins as well, so it will require a larger discussion. I've been focusing on the smaller emoji reaction polish, and plan on coming back to this next week when I have more time.

[MelvinBot]

@eVoloshchak @stitesExpensify @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stitesExpensify]

I'm not sure TBH. Let's put it on hold just in case since the changes are really big

[stitesExpensify]

Update: Fixed all conflicts and bugs on the /app PR. Hoping to get it merged asap to prevent more conflicts

[laurenreidexpensify]

@stitesExpensify how we doing on this one?

[stitesExpensify]

We ran into a big problem last week where reacting with skinTone 0 would break everything due to PHP encoding. That is now fixed, and the /app PR is just waiting for one final review

[laurenreidexpensify]

@stitesExpensify what's the latest here?

[stitesExpensify]

The main issue is no longer happening! 🎉 There were a couple of regressions that are getting taken care of, and then we can work on the clean-up which will complete the migration

[sakluger]

@stitesExpensify I just retested #22061 and the behavior is different from before, but it's still not working as expected. Before, when emoji reacting to the "Completed task" or "Reopened task" message, it added the emoji reaction briefly but then it disappeared. Now, the emoji reaction never appears.

We thought that the fixes for this issue might fix that one too, but it hasn't. Do you think any of the cleanup tasks your working on here will fix that one? Or should we go ahead and make it external?

[stitesExpensify]

Replied in the other issue :)

[laurenreidexpensify]

@stitesExpensify is there an update on this one? Thanks

[stitesExpensify]

Still just cleaning up. I'm removing the Bug tag since the bug is fixed, we're just making the code better.

[laurenreidexpensify]

@stitesExpensify we close?!

[stitesExpensify]

Cleanup has not moved forward at all, I've been pulled onto more important projects. Like I mentioned last week, the bug itself is fixed and not being tracked anymore. @laurenreidexpensify If you want to follow along with the cleanup some more feel free, but otherwise you can un-assign :)

[stitesExpensify]

I've been focused on wave8. I should finally have some time to complete this very soon

[stitesExpensify]

no update

[stitesExpensify]

Closing for #focus on waves per the new guidelines

[iwiznia]

Reopening this because I see a comment saying we will cleanup things and we did not.
This would be a finish what we started task: