Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Contact method - User can not access to verify modal, contact method is disabled. #18031

Closed
1 of 6 tasks
kbecciv opened this issue Apr 26, 2023 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Apr 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #17678

Action Performed:

  1. Go to NewDot and log in with expensifail account
  2. Open Profile from Settings
  3. Select contact method item
  4. Add contact email ( can be email or phone number)
  5. Click on it to procced to verification modal

Expected Result:

User can access to verify modal, contact method is enabled.

Actual Result:

User can not access to verify modal, contact method is disabled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.6.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Recording.2587.mp4
video_89.mp4

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 26, 2023
@MelvinBot
Copy link

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Beamanator Beamanator self-assigned this Apr 27, 2023
@Beamanator
Copy link
Contributor

Helping look into this since it may or may not be due to my PR :D

@Beamanator
Copy link
Contributor

Weird, I'm not seeing this issue - I'm able to easily add new email contact methods, i'll see if I can add a phone number one next

Screen.Recording.2023-04-27.at.10.35.50.AM.mov

@Beamanator
Copy link
Contributor

Here's similar for phone number - I'm able to attempt to add the phone number contact method (it fails, which is expected since I'm not in the same country as that phone number's area code)

Screen.Recording.2023-04-27.at.10.39.06.AM.mov

@Beamanator
Copy link
Contributor

I tried with the same phone number from the OP, saw the command to fail quickly (which is better than infinitely being disabled).

I am going to close this since this doesn't seem like a deploy blocker and I can't reproduce, @kbecciv do you mind testing again when you get the chance and reopening this if this is still a blocker for you? I wonder if we had a site slowdown around when you tested yesterday.

@kbecciv
Copy link
Author

kbecciv commented Apr 28, 2023

@Beamanator I tested this issue with expensifail account on build 1.3.8.5., and contact method is disabled after added a secondary email log in.
Please check the video.
Credential: applausetester+0428abb5@applause.expensifail.com

Recording.2620.mp4

@kbecciv kbecciv reopened this Apr 28, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@Beamanator
Copy link
Contributor

@kbecciv that's super weird, I tried adding a contact method applausetester+0428abb55@applause.expensifail.com (just adding an extra 5 since the one you added has its own account apparently) and I quickly saw the option to enter a magic link 🤔

Can you try testing on v1.3.8-8 since that's the latest? Also can you let me know if you've been testing on good internet or pretty slow internet?

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2023
@kbecciv
Copy link
Author

kbecciv commented May 2, 2023

@Beamanator Issue reproductible in build 1.3.8.8, attached the video.

Recording.2624.mp4

@Beamanator Beamanator added the Needs Reproduction Reproducible steps needed label May 2, 2023
@Beamanator
Copy link
Contributor

Thanks @kbecciv - one more question for you, does that only happen with that one specific email address?

@bfitzexpensify have you been able to reproduce this at all? I'm adding the Needs Reproduction label because I can't seem to reproduce with any new contact method 🙃

@bfitzexpensify
Copy link
Contributor

Hm, no, I am not able to reproduce at all. Flow worked normally for me on staging with both an email address and phone number.

@Beamanator
Copy link
Contributor

Same with me, @bfitzexpensify 🙃

Maybe we can wait to see if @kbecciv is only able to reproduce with that one specific email address... Oh also @kbecciv can you try adding that email address as a secondary login in OldDot?

@melvin-bot melvin-bot bot added the Overdue label May 5, 2023
@Beamanator
Copy link
Contributor

Bump @kbecciv :D

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@kbecciv
Copy link
Author

kbecciv commented May 8, 2023

@Beamanator Checking if I can reproduce it with latest build.

@kbecciv
Copy link
Author

kbecciv commented May 8, 2023

Issue is not reproduced on build 1.3.11.3

Recording.2663.mp4

@bfitzexpensify
Copy link
Contributor

Thanks @kbecciv - ok, let's close this out for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

4 participants