Deploy Checklist: New Expensify 2023-05-09

[OSBotify]

Release Version: 1.3.12-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• useOnNetworkReconnect() #17400
• Create Task FrontEnd Changes #17992
• Enable IOUPreview for bill splits #18143
• Migrate TooltipRenderedOnPageBody and fix tooltip flicker/moving when the content changes #18189
• fix: use placeholder on the search input #18251
• Add support for the heading style inside the quote #18399
• Fix: Update regex of italic in expensify common repo #18406
• Fix styles for MoneyRequestHeader #18467
• Fix input label is moving when it is initially active #18468
• prevent closing shortcut modal by triggering open shortcut #18484
• add proper whitespace between "edited" and html rendered message #18491
• [No QA] create UserMentionRenderer for rendering mentions inside chat #18495
• render loader instead of blank under Onfido flow #18520
• [NewContactPage] fix: same number added twice #18536
• fix avatars missing in IOU preview #18568
• Fix arrow focus shortcut modal local state (v2.0) #18599
• [No QA] Fixes OptionsListUtils test expectations and adds comments #18600
• Additional changes for #17202 #18611
• [CP Stg] Fix bad merge #18619
• [NO QA] Comment change just to bump checklist version #18709

Deploy Blockers:

• Web - Workspace - 404 error in the console appears when navigating to Workspace settings #18650
• [$1000] Split bill - "Payment details not found" for a split with 1 person #18682
• Request Money - Money request preview is displayed twice in chat if there are messages before payment #18696

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.12-0 🚀

[roryabraham]

Lots of very important context in slack:

• https://expensify.slack.com/archives/C07J32337/p1683606295702069?thread_ts=1683598557.487459&cid=C07J32337
• https://expensify.slack.com/archives/C9YU7BX5M/p1683607242187009
• https://expensify.slack.com/archives/C9YU7BX5M/p1683607291217059

TL;DR 1.3.12-0 was already deployed to prod on web + desktop. The correct diff between our last intentional prod deploy and the current production branch (i.e: all the code in this checklist) is here: 1.3.11-5...1.3.12-0

[marcaaron]

Checking off #18696 because we have a tight deadline to get some iteration of Manual Requests out the door as per #18696 (comment)

[mvtglobally]

@marcaaron we are almost done, getting summary in a few

[mvtglobally]

@roryabraham @marcaaron

Regression is completed
PR #17992 is failing with multiple issues #18649, #18647, #18660, #18659
PR #18468 seem failing, #18468 (comment)
PR #18143 pass on all but Desktop. Can you double check the Desktop?

[Beamanator]

Ok so it seems like #18650 was marked as not a deploy blocker so I'll check that off the list

[Beamanator]

Similar with #18682, it looks like it is also reproducible in production so i'll check that off as well

[Beamanator]

Regression is completed
PR #17992 is failing with multiple issues #18649, #18647, #18660, #18659
PR #18468 seem failing, #18468 (comment)
PR #18143 pass on all but Desktop. Can you double check the Desktop?

Looking into these now

[Beamanator]

@mvtglobally to be clear, is the issue with #18468 the part where the form changes size slightly when data populates the fields? I don't see the labels shifting left like in the bug report (here) but maybe I'm missing something?

[Beamanator]

I didn't see #18143 failing when I tested on Desktop, 1.3.11-5 - but @mvtglobally can you specify what exactly wasn't passing in the tests on that PR?

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.12-1 🚀

[mvtglobally]

@Beamanator sorry, I didn't mean to say it's failing on Desktop, we just didn't finish testing it on Desktop. It is pass checking off
PR #18468 more details here #18714

[Beamanator]

Aah that's great! Thanks @mvtglobally 👍 👍

I'm currently waiting for the latest iOS staging build & deploy, then I plan to ship this version 💪

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.12-1 has been deployed to staging 🎉

[Beamanator]

Alright here we go!

[Beamanator]

[Beamanator]

Checked off #17992 and #18468 so we could hopefully get the deploy out

[Beamanator]

But there seems to be a problem with GitHub Status at the moment:

Update - For Actions we are seeing issues for a subset of customers triggering workflow runs and scheduled runs. Workflows using the GITHUB_TOKEN environment variable are also encountering issues.
May 10, 2023 - 14:05 UTC

[marcaaron]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[marcaaron]

[marcaaron]