[HOLD for payment 2023-05-23] [$1000] [HOLD for payment 2023-05-22] Unable to drag and drop an attachment after trying to upload a non-supported attachment.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. On staging.new.expensify.com, upload a non supported file.
2. Close the error message.
3. Drag and drop a supported file to the chat.

Expected result:

Attachment preview modal shows up.

Actual result:

Nothing happens.

Workaround:

Upload the supported file using the ‘Add attachment’ button

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.600.mp4

Screen.Recording.2023-05-12.at.20.02.07.mov

Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683918518994549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e02c3225827dbfe9
• Upwork Job ID: 1658541353564557312
• Last Price Increase: 2023-05-16

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abdulrahuman5196]

Potential PR caused this regression - #18624

[allroundexperts]

Potential PR caused this regression - #18624

@abdulrahuman5196 Spot on!

[akinwale]

This is due to changes in this PR: #18624

The isAttachmentPreviewActive state is not getting properly reset back to false because the onModalHide event handler never gets called when the confirm dialog is displayed due to an invalid attachment error. To fix this, onModalHide should be called in the closeConfirmModal method for the AttachmentModal component.

App/src/components/AttachmentModal.js

Lines 156 to 158 in 293f23b

	closeConfirmModal() {
	this.setState({isAttachmentInvalid: false});
	}

closeConfirmModal() {
    this.setState({isAttachmentInvalid: false});
    if (_.isFunction(this.props.onModalHide)) {
        this.props.onModalHide();
    }
}

[mountiny]

This is fixed, I think the only payment here is $1000 to @rushatgabhane for doing C+ review but its a regression so that should decrease the price paid out on the original issue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: call onModalHide when the confirm modal is closed #18897

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
• [@neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@neil-marcellini] Determine if we should create a regression test for this bug.
• [@neil-marcellini] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

I think we should just pay $1000 to @rushatgabhane here cc @michaelhaxhiu

[rushatgabhane]

@michaelhaxhiu please send the offer to account - Satish Gabhane
Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e02c3225827dbfe9

[melvin-bot]

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Current assignee @neil-marcellini is eligible for the External assigner, not assigning anyone new.

[michaelhaxhiu]

Offer sent to Satish G (on behalf of Rushat). Please DM me when you accept and I'll pay it out, close this!

https://www.upwork.com/jobs/~01e02c3225827dbfe9

[michaelhaxhiu]

paid.