Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-31] Payment issue for E/App PR#19230 #19296

Closed
melvin-bot bot opened this issue May 19, 2023 · 10 comments
Closed

[HOLD for payment 2023-05-31] Payment issue for E/App PR#19230 #19296

melvin-bot bot opened this issue May 19, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Issue created to compensate the Contributor+ member for their work on #19230
E/E issue linked to the PR - https://github.com/Expensify/Expensify/issues/284939.
Contributor+ member who reviewed the PR - @sobitneupane.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d08f7d816a89ad1f
  • Upwork Job ID: 1659586791798657024
  • Last Price Increase: 2023-05-19
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels May 19, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label May 19, 2023
@melvin-bot melvin-bot bot mentioned this issue May 19, 2023
57 tasks
@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d08f7d816a89ad1f

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 19, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented May 19, 2023

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

@Christinadobrzyn
Copy link
Contributor

PR still in the works so waiting on this payment.

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels May 19, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 25, 2023
@Christinadobrzyn
Copy link
Contributor

deployed to production on May 24 - eligible for payment on May 31st

@Christinadobrzyn Christinadobrzyn changed the title Payment issue for E/App PR#19230 [Payment May 31] Payment issue for E/App PR#19230 May 26, 2023
@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels May 26, 2023
@Christinadobrzyn Christinadobrzyn changed the title [Payment May 31] Payment issue for E/App PR#19230 [HOLD for payment 2023-05-31] Payment issue for E/App PR#19230 May 26, 2023
@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Jun 1, 2023
@Christinadobrzyn
Copy link
Contributor

Sorry late on this payment.
No regressions on PR - #19230
Offer sent to @sobitneupane via upwork job posting - https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/24831419

@sobitneupane Let me know when you've accepted the offer so I can pay you!

@sobitneupane
Copy link
Contributor

@Christinadobrzyn Accepted the offer.

@Christinadobrzyn
Copy link
Contributor

Awesome! Paid @sobitneupane in Upwork

@sobitneupane or @luacmartins do you think we need to file a regression test for this?

@luacmartins
Copy link
Contributor

@Christinadobrzyn no need. This should be caught during regular regression tests. I think we're all done here. Closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants