Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA magic code input doesn't autofocus #20599

Closed
6 tasks done
Li357 opened this issue Jun 12, 2023 · 4 comments
Closed
6 tasks done

2FA magic code input doesn't autofocus #20599

Li357 opened this issue Jun 12, 2023 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@Li357
Copy link
Contributor

Li357 commented Jun 12, 2023

Action Performed:

  1. Have 2FA enabled
  2. Log in and enter magic code

Expected Result:

2FA code input should autofocus allowing for immediate entry

Actual Result:

2FA code doesn't autofocus

Workaround:

Click on the first input

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.26-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

noinput.mov

Expensify/Expensify Issue URL:
Issue reported by: @Li357
Slack conversation:

View all open jobs on GitHub

@Li357 Li357 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2023
@Li357 Li357 self-assigned this Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Li357
Copy link
Contributor Author

Li357 commented Jun 12, 2023

I've narrowed it down to the fact the input state is not reset for a magic input when switching between validate code and 2FA code. So focusing the 2FA in the code does not actually allow typing since it's passed max length already. Can be fixed using a clear instead of focus when the 2FA input appears, though we'll probably want to fix the underlying issue.

I'm also working on #20480 which can solve this together

@Li357
Copy link
Contributor Author

Li357 commented Jun 12, 2023

Dupe of #19711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants