[HOLD for payment 2023-07-14] Update the subheader UI and enable parent navigation for all report types

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Task header should now:

• Show the creator as the profile picture, and if it was created within a workspace room show the workspace icon
• The header title will now be the task title
• The header will include a parent link in the header

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01647f0a8e4c9ca872
• Upwork Job ID: 1669462551278919680
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[thienlnam]

Handling this so we can hopefully get a merge today or tommorow

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01647f0a8e4c9ca872

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[thienlnam]

After the conversation here: https://expensify.slack.com/archives/C04QEB4MJEQ/p1686808640587439 this issue is now for updating the header for all report types - @chiragsalian will be taking this on! thank ya

[melvin-bot]

@chiragsalian, @sonialiap, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[chiragsalian]

screenshot for reference. source

[chiragsalian]

I'm not sure for workspace request and thread workspace, why we would want to show,

From <parent report name> in <workspace name>

This results in workspace showing up twice like,

From Duraflame owes $38.05 in Duraflame

I'll confirm with tom tomorrow.

2. Task, DM & workspace, is it From <task owner> or From <parent report name>
3. The complete subheader as a link

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[chiragsalian]

As commented there, i don't think the reported regression was due to the changes here. That regression issue would have occurred even without the code changes here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Thread subheaders and parent navigation #21092

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[sonialiap]

@chiragsalian @0xmiroslav This issue didn't automatically get assigned a price, does $1000 sound fair for the work?

The PR was on feature freeze so if we count from the day the freeze was removed to Miroslav's review, we have 3 days, so by my count the bonus applies. Once the base price for this issue is determined, I will send offer and issue payment with the bonus

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[sonialiap]

@chiragsalian can you please check if the PR on this issue caused the regression?

If there are no objections then I'll price this issue as base $1000 (+/- if there was a regression/bonus)

[0xmiros]

@sonialiap can you please hold my payment until further notice? I am working on some stuff due to recent measurements in my region. And update issue to Monthly. Thanks

[melvin-bot]

@chiragsalian, @sonialiap, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@chiragsalian, @sonialiap, @0xmiroslav Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@chiragsalian, @sonialiap, @0xmiroslav Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@chiragsalian, @sonialiap, @0xmiroslav 12 days overdue. Walking. Toward. The. Light...

[sonialiap]

@0xmiroslav has the payment issue been resolved? Can we issue payment?

[0xmiros]

Still discussing

[sonialiap]

@0xmiroslav has your payment issue been resolved?

[0xmiros]

Let's close this. I am tracking myself. Thanks

[sonialiap]

Sounds good. Please reopen once you're ready to be paid so that the issue is back on my todo list.