[HOLD for payment 2023-08-16] [$1000] Web - On back button press navigates to Confirm task screen instead of hide modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + icon and choose Assign task option
2. Enter title and click on Next button
3. Click on Assign and select any Assign
4. Click on confirm task button
5. Go to task thread
6. Click on Assign
7. Click on back button

Expected Result:

It should hide the modal on click of back button

Actual Result:

on back button press navigates to Confirm task

Workaround:

UNknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-14.at.3.49.29.PM.1.mov

Recording.798.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686738116807699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cb24f67bd54c980
• Upwork Job ID: 1671909296462548992
• Last Price Increase: 2023-07-27
• Automatic offers:
• Pujan92 | Contributor | 25886169
• gadhiyamanan | Reporter | 25886171

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

on back button press navigates to Confirm task screen instead of hide modal

What is the root cause of that problem?

The issue seems to be with the onBackButtonPress event handler for the HeaderWithBackButton component. The code navigates to the "Confirm task" screen instead of hiding the modal.

What changes do you think we should make in order to solve the problem?

To solve this issue, we need to update the onBackButtonPress event handler to hide the modal instead of navigating to the "Confirm task" screen in TaskAssigneeSelectorModal.js

js
// Existing code
<HeaderWithBackButton
    onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}
/>

// Updated code
<HeaderWithBackButton
    onBackButtonPress={() => Navigation.dismissModal()}
/>

This change replaces the Navigation.goBack function with Navigation.dismissModal to hide the modal instead of navigating to the "Confirm task" screen.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

on back button press navigates to Confirm task screen instead of hide modal

What is the root cause of that problem?

onBackButtonPress we are navigating to "NEW_TASK" screen instead back

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 179 to 182 in c2059ef

	<HeaderWithBackButton
	title={props.translate('newTaskPage.assignee')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}
	/>

What changes do you think we should make in order to solve the problem?

we can remove onBackButtonPress from below code because as default it will be navigated to back

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 179 to 182 in c2059ef

	<HeaderWithBackButton
	title={props.translate('newTaskPage.assignee')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}
	/>

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On back button press navigates to Confirm task screen instead of hide modal

What is the root cause of that problem?

In this PR this navigation updation took place where on the back we are navigating ROUTES.NEW_TASK from the Assignee Selection page. This is causing the issue and it will take user to New Task page all the time.

What changes do you think we should make in order to solve the problem?

It seems this navigation part added bcoz if the user refresh on assignee selection page and then click on back it will take the user to the New Task page but for already assigned task we should not want to be land on New Task page. So we need to navigate based on the params(if report id is available then just go back or else for new task part navigate to new task page)

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 181 in 0b7455f

onBackButtonPress={() => Navigation.goBack(ROUTES.NEW_TASK)}

Need to update the condition to

onBackButtonPress={() => (props.route.params && props.route.params.reportID) ? Navigation.goBack() : Navigation.goBack(ROUTES.NEW_TASK)}

Result

Screen.Recording.2023-06-21.at.7.05.03.PM.mov

Screen.Recording.2023-06-21.at.7.08.41.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cb24f67bd54c980

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[isabelastisser]

I will be OOO until July 5, so assigning another team member. SO for reference.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

Didn't get to today, but will tackle tomorrow!

[dylanexpensify]

@eVoloshchak can we get reviews on proposals today??

[Pujan92]

@eVoloshchak Thanks, I think reviewed stamp is required to assign it to the internal engineer.

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[isabelastisser]

@Pujan92, I assigned you now. You can start working on this now, thanks!

[Pujan92]

@eVoloshchak PR is ready for review!

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Pujan92 got assigned: 2023-08-01 18:05:07 Z
• when the PR got merged: 2023-08-07 13:32:41 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Web/Desktop - On back button press navigates to Confirm task screen instead of hide modal #24055

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligable for Manual Requests)
• @Pujan92 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pecanoro]

@eVoloshchak Can you complete the list so we can proceed with the payment?

@isabelastisser All yours to handle payments!

[isabelastisser]

Payment summary:

• Issue reported by @gadhiyamanan $250 - previously paid in Upwork.
• C+ review: @eVoloshchak $1000. New dot payment
• Approved proposal: @Pujan92 $1000

[isabelastisser]

@eVoloshchak please complete the checklist when you have a chance, thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: that's the way it was implemented initially in Create Task FrontEnd Changes #17992,
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is a typical bug with modal navigation
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  This has a very low impact, doesn't break the UX, a regression test isn't necessary I think

[JmillsExpensify]

Reviewed the details for @eVoloshchak. $1,000 approved for payment via NewDot based on BZ summary.

[isabelastisser]

• All the payments were processed.
• A regression test is not needed.

We are all set here.